Skip to content

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Apr 17, 2024

In llvm/llvm-project@9067070 they ended up largely reverting
llvm/llvm-project@e817966. This means the change we did in
b378059 is now only corrct for LLVM 18...so we have to adjust again.

@rustbot label: +llvm-main

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

Some changes occurred in tests/ui/check-cfg

cc @Urgau

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Apr 17, 2024
@rust-log-analyzer

This comment has been minimized.

@durin42 durin42 force-pushed the llvm-19-riscv-feature branch from f3ff6e2 to 7b85355 Compare April 17, 2024 19:19
@rust-log-analyzer

This comment has been minimized.

In llvm/llvm-project@9067070 they ended
up largely reverting
llvm/llvm-project@e817966. This means
the change we did in
rust-lang/rust@b378059 is now only
corrct for LLVM 18...so we have to adjust again.

@rustbot label: +llvm-main
@durin42 durin42 force-pushed the llvm-19-riscv-feature branch from 7b85355 to 22b704b Compare April 17, 2024 20:15
@Manishearth
Copy link
Member

r? llvm

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

Failed to set assignee to llvm: cannot assign: response: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/assignees#add-assignees-to-an-issue"}

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@Manishearth
Copy link
Member

r? cuviper

@cuviper
Copy link
Member

cuviper commented Apr 17, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 17, 2024

📌 Commit 22b704b has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 18, 2024
…uviper

llvm: update riscv target feature to match LLVM 19

In llvm/llvm-project@9067070 they ended up largely reverting
llvm/llvm-project@e817966. This means the change we did in
rust-lang/rust@b378059 is now only corrct for LLVM 18...so we have to adjust again.

`@rustbot` label: +llvm-main
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#124041 (Fix copy path button)
 - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups)
 - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`)
 - rust-lang#124072 (Remove libc from more tests)
 - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19)
 - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124041 (Fix copy path button)
 - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups)
 - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`)
 - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19)
 - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 90013ff into rust-lang:master Apr 18, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
Rollup merge of rust-lang#124090 - durin42:llvm-19-riscv-feature, r=cuviper

llvm: update riscv target feature to match LLVM 19

In llvm/llvm-project@9067070 they ended up largely reverting
llvm/llvm-project@e817966. This means the change we did in
rust-lang/rust@b378059 is now only corrct for LLVM 18...so we have to adjust again.

``@rustbot`` label: +llvm-main
@durin42 durin42 deleted the llvm-19-riscv-feature branch December 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants